In order to use the FindBugs annotations, you need to include annotations.jar and jsr305.jar from the FindBugs distribution on your classpath. If you are sure that you want the @SuppressFBWarnings annotation only (and not the others), then annotations.jar alone would be sufficient. You can find the two JARs in the lib folder of the FindBugs … Read more
@SuppressFBWarnings on a field only suppresses findbugs warnings reported for that field declaration, not every warning associated with that field. For example, this suppresses the “Field only ever set to null” warning: @SuppressFBWarnings(“UWF_NULL_FIELD”) String s = null; I think the best you can do is isolate the code with the warning into the smallest method … Read more
If the nested class does not access any of the variables of the enclosing class, it can be made static. The advantage of this is that you do not need an enclosing instance of the outer class to use the nested class.
Your implementation is wrong 😉 Basically docs says (I’ll paraphrase and emphasise): @throws NullPointerException if input is null and the concrete function implementation does not accept null arguments By implementing your function you must decide if it accepts nulls or not. In first case: private static final class Example implements Function<MyBean, String> { @Override @Nullable … Read more
You are retrieving all the keys (accessing the whole map) and then for some keys, you access the map again to get the value. You can iterate over the map to get map entries (Map.Entry) (couples of keys and values) and access the map only once. Map.entrySet() delivers a set of Map.Entrys each one with … Read more
I came from the future to save your lives. Here (in the future), LINT does check for missing permissions as you can see on LINT checks. So, go to your AndroidManifest.xml and remove all tags <uses-permission> using Android permissions (meaning, don’t delete permissions that belong to your app, such as UA_DATA and C2D_MESSAGE). Then run … Read more
Findbugs is flagging up that falling through from one case to the next is generally not a good idea if there’s any code in the first one (although sometimes it can be used to good effect). So when it sees the second case and no break, it reports the error. So for instance: switch (foo) … Read more
The issue is that Integer.valueOf returns an Integer, not an int, but your someOtherMethod expects an int. Findbugs is basically warning you that you’re doing it a long-winded way that involves potentially creating an object (the Integer) that you don’t need which you’re then immediately going to unbox by passing it to someOtherMethod(int), e.g.: String … Read more
At the time of this writing, @GuardedBy isn’t fully implemented by Findbugs, and is mostly just for documentation. (It is partially implemented.) I always use @GuardedBy(“readwritelock”) or the object that I use to synchronize. For example of the latter: class Example { private Object lock = new Object(); @GuardedBy(“lock”) private Stuff innards = …; public … Read more
One problem with ONLY closing the connection and not the result set, is that if your connection management code is using connection pooling, the connection.close() would just put the connection back in the pool. Additionally, some database have a cursor resource on the server that will not be freed properly unless it is explicitly closed.