You’re missing a return statement. When the compiler looks at your code, it’s sees a third path (the else you didn’t code for) that could occur but doesn’t return a value. Hence not all code paths return a value. For my suggested fix, I put a return after your loop ends. The other obvious spot … Read more
Tried FxCop? It’s integrated into VS as “Code Analysis” In the newer versions of Visual Studio, it is called “Microsoft Code Analysis” and can be downloaded from the Visual Studio Marketplace: https://marketplace.visualstudio.com/items?itemName=VisualStudioPlatformTeam.MicrosoftCodeAnalysis2017
Visual Studio includes FxCop + more. From the developer blog of FxCop: Sorry about my ignorance, but I assume FxCop is completely separate from the Code Analysis in VSTS? More specifically, I assume that if I install the new version of FxCop, VSTS will not take advantage (no shared code?)? If this is the case, … Read more
Visual Studio Code Analysis has been merged with Intellisense and can now be viewed from the Error window. When you select “Build+Intellisense” or “Intellisense” your code analysis warnings will show up there. You no longer need to build your solution to see them there. This is one of the perks of the new Roslyn based … Read more
I’ve just had the same problem after upgrading from VS2013 to VS2015. My solution was: On the project properties go to the Code Analysis section. Select the Browse option on the list of rule sets. Browse to the VS2015 rule sets folder. C:\Program Files (x86)\Microsoft Visual Studio 14.0\Team Tools\Static Analysis Tools\Rule Sets Pick a rule … Read more
SourceInsight and Understand for C++ are the best tools you can get for c/c++ code analysis including flow charts.
Suppression of a code analysis warning for a namespace and all its descendant symbols is possible since Visual Studio 2019: [assembly: System.Diagnostics.CodeAnalysis.SuppressMessage( “Microsoft.Naming”, “CA1707:IdentifiersShouldNotContainUnderscores”, Justification = “Test methods require underscores for readability.” Scope = “namespaceanddescendants”, Target = “Company.Product.Tests”)] Scope – The target on which the warning is being suppressed. If the target is not specified, … Read more
You should suppress the warnings in this case. Code that deals with disposables should be consistent, and you shouldn’t have to care that other classes take ownership of the disposables you created and also call Dispose on them. [SuppressMessage(“Microsoft.Usage”, “CA2202:Do not dispose objects multiple times”)] public static byte[] Encrypt(string data, byte[] key, byte[] iv) { … Read more
Python caches integers in the range [-5, 256], so integers in that range are usually but not always identical. What you see for 257 is the Python compiler optimizing identical literals when compiled in the same code object. When typing in the Python shell each line is a completely different statement, parsed and compiled separately, … Read more
For code in your project, the only way is adding a declaration saying that you expected that — possibly protected by an if False so that it doesn’t execute (the static code-analysis only sees what you see, not runtime info — if you opened that module yourself, you’d have no indication that main was expected). … Read more