With Flying Saucer, how do I generate a pdf with a page number and page total on every page at the footer?

You could also try a slightly more succinct approach:

@page {
  @bottom-right {
    content: "Page " counter(page) " of " counter(pages);
  }
}

You need to put this in your css/style, and you do not need to add an extra footer HTML element.