I assume your class is a bean that by definition implements Serializable. A transient variable will be excluded from the serialization process. If you serialize and then deserialize the bean the value will be actually have the default value. PMD assumes you are dealing with a serializable bean here. For a bean it is expected … Read more
DD and DU anomalies (if I remember correctly—I use FindBugs and the messages are a little different) refer to assigning a value to a local variable that is never read, usually because it is reassigned another value before ever being read. A typical case would be initializing some variable with null when it is declared. … Read more
I know is an old post but I just had the same need (almost) and I solve it using a LineIterator from FileUtils in Apache Commons. From their javadoc: LineIterator it = FileUtils.lineIterator(file, “UTF-8”); try { while (it.hasNext()) { String line = it.nextLine(); // do something with line } } finally { it.close(); } Check … Read more
See this short introduction to log4j. The issue is in using System.out to print debugging or diagnostic information. It is a bad practice because you cannot easily change log levels, turn it off, customize it, etc. However if you are legitimately using System.out to print information to the user, then you can ignore this warning.
To get Eclipse to not flag the @SuppressWarnings(“PMD”) annotation, look under the menu headings Java -> Compiler -> Errors/Warnings -> Annotations -> Unhandled Token in ‘@SuppressWarnings’ and set it to ignore. Right on the PMD page.
You should add the maven-jxr-plugin to the reportingPlugin section. <reporting> <plugins> <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-jxr-plugin</artifactId> <version>3.3.0</version> </plugin> </plugins> </reporting> Re run it and enjoy. BTW, maybe you’ll need to run once the jxr:jxr goal to first generate some file that will be used by pmd.
You should definitely use FindBugs. In my experience, the false-positive rate is very low, and even the least-critical warnings it reports are worth addressing to some extent. As for Checkstyle vs. PMD, I would not use Checkstyle since it is pretty much only concerned with style. In my experience, Checkstyle will report on a ton … Read more
It means you should use logging framework like logback or log4j and instead of printing exceptions directly: e.printStackTrace(); you should log them using this frameworks’ API: log.error(“Ops!”, e); Logging frameworks give you a lot of flexibility, e.g. you can choose whether you want to log to console or file – or maybe skip some messages … Read more
I’m using both. I think they complement each other. As you said, PMD works on source code and therefore finds problems like: violation of naming conventions, lack of curly braces, misplaced null check, long parameter list, unnecessary constructor, missing break in switch, etc. PMD also tells you about the Cyclomatic complexity of your code which … Read more
Sonar will run CheckStyle, FindBugs and PMD, as well as a few other “plugins” such as Cobertura (code coverage) by default for Java projects. The main added value, however, is that it stores the history in a database. You can then see the trend. Are you improving the code base or are you doing the … Read more