I had a look at the code in ThreadLocal<T> to see what the current Dispose is doing and it appears to be a lot of voodoo. Obviously disposing of thread-related stuff. But it doesn’t dispose of the values if T itself is disposable. Now, I have a solution – a ThreadLocalDisposables<T> class, but before I … Read more
The general rule of resources is that: He who owns the resource is responsible of disposing of it. This means that if a class owns a resource, it should either dispose of it in the same method that it created it in (in which case the disposable is called an ephemeral disposable), or if that’s … Read more
I’m sure most people are aware of it, but since this question is still among the top results when searching for “IDisposable Java” (#2 result for me just now), and it’s still not mentioned here… Things have changed with Java 7: there now is AutoCloseable. Which isn’t tied to streams and supported by the new … Read more
If you want to highlight disposable objects differently in VS please check out this post. I personally prefer Resharper answer as I always use R#. If you just want to figure out if your object is an instance of some interface you can right-button-click on the variable name and Navigate -> Object Browser or Go … Read more
Dispose is for releasing “unmanaged” resources (for example, sockets, file handles, Bitmap handles, etc), and if it’s being called outside a finalizer (that’s what the disposing flag signifies, BTW), for disposing other IDisposable objects it holds that are no longer useful. “Unmanaged” resources aren’t managed by the CLR (hence the name), and GC doesn’t mess … Read more
There is no single answer, it depends on your scenario, and the key point is ownership of the disposable resource represented by the property, as Jon Skeet points out. It’s sometimes helpful to look at examples from the .NET Framework. Here are three examples that behave differently: Container always disposes. System.IO.StreamReader exposes a disposable property … Read more
The CLR documentation states that whoever creates a Disposable object is responsible for calling Dispose. In this case the object is created by Ninject. That means you should not call Dispose explicitly. Ninject disposes every Disposable object that has another scope other than InTransientScope as soon as the scope object to which the created object … Read more
When implementing the dispose pattern you might also add a finalizer to your class that calls Dispose(). This is to make sure that Dispose() always gets called, even if a client forgets to call it. To prevent the dispose method from running twice (in case the object already has been disposed) you add GC.SuppressFinalize(this);. The … Read more
For sure it’s not a good prartice. The caller should decide when he is finished using the IDisposable object, not an object itself.
When I just override the Dispose(bool disposing) call, it feels really strange stating that I implement IDisposable without having an explicit Dispose() function (just utilizing the inherited one), but having everything else. This is something you shouldn’t be concerned with. When you subclass an IDisposable class, all of the “Dispose pattern” plumbing is already being … Read more