This seems like a perfectly good interface for a module who’s job is to do a one-time fetch of some data.
The data is obtained async so a promise makes sense for that. The goal is to fetch the data just once and then let all places this module gets used just have access to that original data. A promise works great for that too because it’s a one-shot device that remembers its state.
Personally, I’m not sure why you need the getId()
and getName()
methods when you could just offer direct access to the properties, but either can work.
A downside to this interface is that there is no means of requesting a fresh copy of the data (newly loaded from the DB).