How do I cancel form submission in submit button onclick event?

You are better off doing…

<form onsubmit="return isValidForm()" />

If isValidForm() returns false, then your form doesn’t submit.

You should also probably move your event handler from inline.

document.getElementById('my-form').onsubmit = function() {
    return isValidForm();
};