Find model records by ID in the order the array of IDs were given

Editor’s note:
As of Rails 5, find returns the records in the same order as the provided IDs (docs).

Note on this code:

ids.each do |i|
  person = people.where('id = ?', i)

There are two issues with it:

First, the #each method returns the array it iterated on, so you’d just get the ids back. What you want is a collect

Second, the where will return an Arel::Relation object, which in the end will evaluate as an array. So you’d end up with an array of arrays. You could fix two ways.

The first way would be by flattening:

ids.collect {|i| Person.where('id => ?', i) }.flatten

Even better version:

ids.collect {|i| Person.where(:id => i) }.flatten

A second way would by to simply do a find:

ids.collect {|i| Person.find(i) }

That’s nice and simple

You’ll find, however, that these all do a query for each iteration, so not very efficient.

I like Sergio’s solution, but here’s another I would have suggested:

people_by_id = Person.find(ids).index_by(&:id) # Gives you a hash indexed by ID
ids.collect {|id| people_by_id[id] }

I swear that I remember that ActiveRecord used to do this ID ordering for us. Maybe it went away with Arel 😉