Is there a better way to combine two string sets in java?

Since a Set does not contain duplicate entries, you can therefore combine the two by:

newStringSet.addAll(oldStringSet);

It does not matter if you add things twice, the set will only contain the element once… e.g it’s no need to check using contains method.