-shouldChangeCharactersInRange
gets called before text field actually changes its text, that’s why you’re getting old text value. To get the text after update use:
[textField2 setText:[textField1.text stringByReplacingCharactersInRange:range withString:string]];