You should always run untrusted code in a separate process, which is exactly what the sandbox module does. A simple reason is that vm.runInNewContext('while(true){}', {}) will freeze node.
It starts by spawning a separate process, which will later send the result serialized to JSON on its stdout. The parent process continues executing regardless of what the child does and can trigger a timeout.
The untrusted code is then wrapped in a closure with strict mode (in regular JavaScript, you can use arguments.callee.caller to access data outside of your scope). Finally, a very limited global object is passed to prevent access to node’s API. The untrusted code can only do basic computation and has no access to files or sockets.
While you should read sandbox’s code as an inspiration, I wouldn’t recommend using it as is:
- The code is getting old and hasn’t been updated for 7 months.
- The Child Process module in node already provides most of the features you need, especially child_process.fork().
- The IPC channel provided by child_process.fork probably has better performances.
For increased security, you could also consider using setuid-sandbox. It’s the code used by Google Chrome to prevent tab processes from accessing the file system. You would have to make a native module, but this example seems straightforward.