- Option 1: clean & explicit. Works like a charm
- Option 2: more procedural, less stream-like. Works like a charm. Note that your stream will not get a ‘complete’ event which can cause unexpected behaviour
- Option 3: takeWhile – will have the subscription stay around untill an emission is created and then the takeWhile is evaluated. This can lead to unexpected behaviour. Still, in the end works
TLDR; there is no wrong here. Choose what you see fits your needs and communicates your intent.
Ben Lesh has also written quite a good post about the different ways to unsubscribe https://medium.com/@benlesh/rxjs-dont-unsubscribe-6753ed4fda87
His opinion:
You should probably be using operators like
takeUntilto manage your RxJS subscriptions. As a rule of thumb, if you see two or more subscriptions being managed in a single component, you should wonder if you could be composing those better.